Feat/dwa #196
Feat/dwa #196
Conversation
|
Checking this out. Thanks for the contribution @Johnnyevans32 |
| export function useWeb5() { | ||
| const { web5 } = storeToRefs(useWeb5Store()) | ||
|
|
||
| const protocol = 'https://didcomm.org/dwa-starter-vue' |
There was a problem hiding this comment.
since they are both framework agnostic, can you please maintain the original files below and connect with this composable?
- https://github.com/TBD54566975/tbd-examples/blob/main/javascript/dwa-starter-react-vite/src/lib/todo-dwn-repository.ts
- https://github.com/TBD54566975/tbd-examples/blob/main/javascript/dwa-starter-react-vite/src/web5/protocols.ts
this will make things simpler to maintain across all the dwa-starter examples
There was a problem hiding this comment.
done with this @leordev, I found the react implementation of the web5 composable a bit confusing hence why I previously opted for a different version
There was a problem hiding this comment.
What I suggested was to copy these two files to your project and use them in the useWeb5 or in the best way you can think of. Is it possible?
There was a problem hiding this comment.
ah ok got that now
There was a problem hiding this comment.
should be ok now i hope @leordev
| await page.goto('/settings') | ||
| await expect(page.locator('h1')).toHaveText('Settings') | ||
| }) | ||
| // TODO: mock web5 connection for access to settings page |
There was a problem hiding this comment.
do you need help with this test or are you planning to add it back in one of the other projects tasks?
There was a problem hiding this comment.
yeah I do actually, i was going to get more info on this after finishing up the main pages components
There was a problem hiding this comment.
lets do this... hold off on this test for now, and lets merge this pr as soon as you address my points above. then after that I can work on mocking/setting up the connection in playwright while you work on your next task. this way we dont block you!
There was a problem hiding this comment.
gotcha thanks!
|
hi @leordev, have you had the time to look at the updates I made, if there are additional changes I need to make. |
|
@Johnnyevans32 i tested and this is ready to go..the only thing that needs to be fixed before I approve and merge is the conflict on the pnpm lock file. Thank you! |
sorted now @blackgirlbytes |
|
Hey @taniashiba ..after we remove the leaderboard action from github..we need to manually add ANOTHER 10 points for @Johnnyevans32 to the leaderboard because this PR he did two issues in one..a large and a medium. So instead of having 115..he would have 115 + 10 (from other PR) + 10 (from this PR) = 135 |
What type of PR is this? (check all applicable)
Description
This PR adds Web5 connection converting it to a DWA.
Related Tickets & Documents
Resolves #66
Resolves #75
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-10-06.at.14.mp4
Added code snippets?
Added tests?
No tests? Add a note
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?