-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An Action+Route to send the verification email again after expiration #35
Comments
Yes, I've totally failed in trying to create a 'send new verification email' action. Is there an example of how it would be done? I am surprised it is not a part of the bundle as it will always be essential to have one. |
If you follow the fact that a user should be logged in to verify his email (debate en #27), then just catch an additionnal ExpiredSignatureException from $this->emailVerifier->handleEmailConfirmation($request, $user); and resend the mail using the code from register (you can add a different flash message). if you added the email on the URL ( suggestion on #31), get the user object from the email, and resend the mail using the code from register. |
Oh I see, it is as simple as ending a new email. Clever. I was overthinking it. Thanks @adazmy |
But still... this should be (in my opinion) implemented directly by the bundle... and maybe have it's own action/route if we want to add this in a message. |
Good Morning! Off the top of my head, this is a feature that would be best implemented in the Maker Bundle code. Technically it is possible currently with a little bit of leg work. I'll review the code bases and see how to best implement this over in Maker Bundle. |
This feature would be useful too! |
@jrushlow , Hi there! The main issue (a consequence of not using database entries) is that there is no way to keep track of that without making database entries. So I think some code from the "password reset" package needs to be used in this package to make this work. The symfonycasts password reset package also uses a table dedicated to keep track of that and fix the concern above. Let me know what you think! |
I second @vincentcox's idea. The password reset bundle already has most of the logic (and config) which could be used here as well. |
Hi there! Thanks |
@jrushlow It's been quite some time since there was an update on this issue. Could you give as some additional information on what the status is? Is this feature still going to be implemented here / Maker bundle one day? Or should we just implement a workaround ourselves? |
@jrushlow It's been well over a year since you've mentioned in #50 that the functionality was "currently planned". Could you please give us a status update? |
I’d welcome a PR to MakerBundle to generate this and/or any potential helper code in this bundle that would make it easier :) |
hello ! |
Hey there! 😃 I'm also interested in an official solution for that, trying to avoid too much non-standard approaches. Since the mentionned solution with Cheers! |
Just a side note about why there is no action or route inside the expiration error message to ask for a new verification email?
thanks!
The text was updated successfully, but these errors were encountered: