UI problem in latest production build

[akomba]

Environment/Browser

Firefox 77.0.1 (64-bit) on Ubuntu 20.4

Description

When running the latest version of the update-web3 branch in PRODUCTION mode, the UI gets recursive. The rightmost pane of the screen attempts to show the whole application again.

Steps to reproduce

1. git clone repo
2. cd ethereum-studio
3. git checkout update-web3
4. npm i
5. npx lerna bootstrap --hoist
6. npm run build
7. serve -s www
8. visit page

Expected result

I expect to see the proper UI (that shows when running the same project in dev mode with "npm start")

Actual result

The rightmost pane of the UI displays the whole UI again in a recursive manner

Reproducible

100%

[javier-tarazaga]

@lovrobiljeskovic could you please check this one out?

[javier-tarazaga]

@akomba quick question, why do you need this specific branch actually merged for your course? This is an internal instance of web3 which should not really affect the current functionality.

We are currently doing this change as we will soon start using web3 a bit more and we wanted to update the library to the latest stable version.

[akomba]

The main branch dies after npm start:

editor: Starting the development server...
editor: Failed to compile.
editor: /home/user/code/ethereum-studio/packages/editor/src/components/projectEditor/paneAction/index.tsx
editor: Type error: No overload matches this call.
editor:   Overload 1 of 2, '(props: Readonly<TooltipProps>): Tooltip', gave the following error.
editor:     Type 'string' is not assignable to type 'number | undefined'.
editor:   Overload 2 of 2, '(props: TooltipProps, context?: any): Tooltip', gave the following error.
editor:     Type 'string' is not assignable to type 'number | undefined'.  TS2769
editor:     28 |     return (
editor:     29 |         <div className={style.toggle}>
editor:   > 30 |             <Tooltip title={tooltipText} position='bottom' distance='30'>
editor:        |                                                            ^
editor:     31 |                 <button className={'btnNoBg'} onClick={onClick}>
editor:     32 |                     {icon}
editor:     33 |                 </button>

The above is the error I am getting if I follow the installation instructions on the master branch.

[akomba]

Tried on ubuntu and osx

[javier-tarazaga]

Hi thanks @akomba,

What I meant is why are you trying to use a branch which is not master. This branch is a in-development mode branch and needs to be finally fixed before merging it to master. Thats why I was asking why are you trying to figure out if there was something you specifically needed in this branch or it was just trying to help out with that feature :)

[sabhiram]

@javier-tarazaga - pretty sure this happens on master as well. Just a curious bystander that's all. Confirmed on #5fbdafaf