Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App return all product reviews with invalid value of param "page" #327

Open
TetianaPerinha opened this issue Jun 20, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TetianaPerinha
Copy link
Collaborator

TetianaPerinha commented Jun 20, 2024

Describe the bug
When sending a GET product reviews request with an invalid value of param "page" the system returns all product reviews

To Reproduce
Send the GET request as below use value for param page = %, +, #

curl --location 'https://iced-latte.uk/backend/api/v1/products/e6a4d7f2-d40e-4e5f-93b8-5d56ce6724c5/reviews?page={value}

Expected behavior
The system should reject the request with 400 HTTP Status code "error": "Bad Request".

Actual result
System accept the request and returns all product reviews.

get all reviews with param page = # get all reviews with param page = + get all review with param page = %
@TetianaPerinha TetianaPerinha added bug Something isn't working good first issue Good for newcomers labels Jun 20, 2024
@Prankurtiwari
Copy link
Contributor

Hi @TetianaPerinha Please assign this bug to me and I will start working on this.

@praguru14
Copy link

Hi , has this been fixed? I checked your API and it seems like that it was fixed

@Prankurtiwari
Copy link
Contributor

Prankurtiwari commented Oct 3, 2024

Hi @praguru14, I dont think the issue is fixed, at least I have not fixed it currently I have been following up with this. Looks like the project managers are not very active here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants