Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely accidental use of ENTRYPOINT #76

Open
coderanger opened this issue Feb 27, 2019 · 2 comments
Open

Likely accidental use of ENTRYPOINT #76

coderanger opened this issue Feb 27, 2019 · 2 comments

Comments

@coderanger
Copy link

The included run.sh is more of a CMD than an ENTRYPOINT given that it doesn't take options or function as a shell.
@maimaisie
Copy link
Collaborator

Hi @coderanger thank you for reporting this issue. Do you have any recommendation on how this can be addressed?

@coderanger
Copy link
Author

Rather than ENTRYPOINT ["/bin/bash", "/run.sh"], use CMD ["/bin/bash", "/run.sh"]. That sets the default command, rather than the default entrypoint :) They seem similar but work differently inside the container tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderanger @maimaisie