Fix/refactor comma correction logic #8972
Open
+35
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate Arabic comma regex replacements into a lazy-initialized dictionary to enhance maintainability and readability. Simplify redundant regex instantiation by using a loop-based approach. Also, optimize the method for removing extra commas before sentence-ending characters by using a character array. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
Removed unnecessary checks for opening parentheses and brackets following commas. This prevents inappropriate fixes where commas precede these characters. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
Make NeutralSentenceEndingChars publicly accessible by changing its access modifier to public. Also, refactor the IsNextCharSentenceClosingSymbol method in FixCommas to utilize the NeutralSentenceEndingChars for more concise and efficient logic. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.