Use proxy if configured in HttpClient settings ✨ #8945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
ivandrofly
changed the title
# Conflicts: # src/ui/Forms/Tts/TextToSpeech.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the application's HTTP client creation to utilize a custom
HttpClientfactory, ensuring that all HTTP requests respect any proxy settings specified in the configuration.Key changes:
HttpClientcreation method is introduced, which includes proxy settings if configured.DownloaderFactoryclass has been renamed toHttpClientFactoryto accurately reflect its purpose.HttpClientinstantiations have been systematically replaced with calls toHttpClientFactory.CreateProxiedHttpClient.This refactor enhances the maintainability and configurability of HTTP requests within the application, promoting a more robust and adaptable architecture.