Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorToDialog - Dash not being added when a different character speaks (color change) #221

Open
shootlazer opened this issue Aug 6, 2022 · 0 comments

Comments

@shootlazer
Copy link

shootlazer commented Aug 6, 2022

The plugin successfully adds a dash when a line next to a colored line has no color.
But it doesn't add it when there are lines with different colors.

For example.

Currently it turns this:

1
00:00:01,280 --> 00:00:02,639
Wow! #blue
I can believe this! #blue

2
00:00:02,720 --> 00:00:04,039
This is amazing! #blue
This is terrible! #red

Into this

1
00:00:01,280 --> 00:00:02,639
Wow!
I can't believe this!

2
00:00:02,720 --> 00:00:04,039
This is amazing!
This is terrible! 

**When it actually should be:

1
00:00:01,280 --> 00:00:02,639
Wow!
I can't believe this!

2
00:00:02,720 --> 00:00:04,039
 - This is amazing!
 - This is terrible! 

Or even this, (although it's not that usual)

1
00:00:01,280 --> 00:00:02,639
Wow!
I can't believe this!

2
00:00:02,720 --> 00:00:04,039
This is amazing! ((no dash since the previous line comes from the same character)
 - This is terrible! 

Otherwise, it's "destroying" info,
Currently it works if one of the lines have no color, but it won't work if the two of them are already colored.

I can't seem to replicate the "TestDialog3" result from ColorToDialogUnitTest.cs , so I'm not sure if it's working as intended.

tl;dr the plugin won't add a dash if all lines contain a "<font " tag

@shootlazer shootlazer changed the title ColorToDialog - Add a dash when a different character speaks (color changes) ColorToDialog - Dash not being added when a different character speaks (color change) Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant