Set Access property explicitly

[rvanbekkum]

It would be helpful if a code analysis rule could give a warning on setting the Access property explicitly.
This holds for all object types where this property can be added.
I think the default severity could be set to Disabled, as it is not something everyone might want to get warnings about, but it would be nice to make developers aware of the possibility of changing it from public to something else, have them think about the accessibility of the objects they create: "should these objects actually be part of the public API?"

[StefanMaron]

maybe a duplicate of #27 ?

[rvanbekkum]

No, although closely related, but with this I am requesting a code analysis rule that checks if the Access property is defined in the object.
So, what I would like is that all objects get an access modifier, e.g., Access = Public; even if that is the default, but then at least you know that that is intentional.

For issue #27, the AL XML Documentation extension covers that for the most part in VS Code, although it cannot be included in build pipelines as easily, as far as I know.

[StefanMaron]

Got it :)

[StefanMaron]

I will remove Page and XML Port as it is not supported for this property. Should I also add table fields?

https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/properties/devenv-access-property

[rvanbekkum]

Or ... have LC0011 only check it at object level for now. And if/when someone wants/needs it for field-level checks, then look into adding that as well? :)

[StefanMaron]

I see no disadvantage in adding it disabled by default, and I think it would be straight forward to align this rule with the documentation. I get that if field warning would be always enabled this adds a huge overhead compared to objects level only, hence the option to enable/disable field check

[rvanbekkum]

Me neither, I don't think it would be difficult to implement either. :) I agree that it would be better to have that disabled, as adding an explicit property value for all table fields would add a huge overhead like you say.

[StefanMaron]

New version is released!

[rvanbekkum]

Great! 😄