LC0024 vs Find Event

[pri-kise]

I like the idea to avoid an unncessary semicolon.

https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0024

I have one problem with this rule currently.
Th Find Event Action adds automatically a semicolon.
Therefore I don't know why Microsoft does this, but maybe we'll need an issue on the AL Language Repo to dicuss this code styling warning.

[fvet]

When reporting to MS, maybe also include the 'Subscribe to Event' (AL Explorer) and 'Implement interface' code action as reported here
#331

[pri-kise]

Well at first the documentation for the AL Language should mention this best practice on semicolons.
Maybe anywhere on the statement documentation of the AL Language.
https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-al-control-statements#al-compound-statements

[Arthurvdv]

I've started an topic on Twitter/X to receive some help on this (https://twitter.com/arthrvdv/status/1727729430737342791) and our BC community is awesome! 🥳 Also interesting to read the details behind this semicolon-thing.

A) Created an issue for the AL Language to change the default behavior on this: microsoft/AL#7598.
B) @waldo1001 had voluntarily created an PR to remove this from his snippets: waldo1001/crs-al-language-extension#294.

From a code linting perspective, this is a great step in the right direction! With both feet on the ground: "..it's just a semicolon.." 😅

I'm not sure what to do in de statement documentation of the AL Language. If as default is never is being added, do we need to explicit document this in the documentation that it's not necessary to add something that's default not there?

[Arthurvdv]

@pri-kise, great work on MicrosoftDocs/dynamics365smb-devitpro-pb#3127

[fvet]

@pri-kise Did you miss some or was I too eager in fixing some other code samples too?

https://github.com/MicrosoftDocs/dynamics365smb-devitpro-pb/pull/3131/files

[Arthurvdv]

I've asked @anzwdev for an code action in the AZ AL Dev Tools here: anzwdev/al-code-outline#510.

This wil be much more easily to use then the current RegEx in the wiki on this rule.