Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetHook: Add 64-bit project config and CI build #1246

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Conversation

psychonic
Copy link
Member

@psychonic psychonic commented Aug 19, 2023

This adds an x64 solution/project configuration for NetHook, as well as adding these builds to the existing CI flow.

@psychonic psychonic changed the title Add 64-bit project config and CI build NetHook: Add 64-bit project config and CI build Aug 19, 2023
@psychonic psychonic marked this pull request as ready for review August 19, 2023 16:55
@yaakov-h
Copy link
Member

I think the artifact uploads from each configuration might be stomping over each-other?

@psychonic
Copy link
Member Author

I think the artifact uploads from each configuration might be stomping over each-other?

🤦Indeed they were. That's been corrected now.

@psychonic psychonic merged commit 1220d3c into master Oct 18, 2023
13 checks passed
@psychonic psychonic deleted the psy/build-x64 branch October 18, 2023 12:32
@xPaw xPaw added this to the 2.5.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants