Remove cast and use UnreachableException

SteamRE · Nov 16, 2023 · ed48fb1 · ed48fb1
1 parent 4a5b918
commit ed48fb1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/SteamKit2/Tests/CallbackManagerFacts.cs b/SteamKit2/Tests/CallbackManagerFacts.cs
@@ -32,7 +32,7 @@ void action( CallbackForTest cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe( ( Action<CallbackForTest> )action ))
+            using (mgr.Subscribe<CallbackForTest>( action ))
             {
                 PostAndRunCallback(callback);
             }
@@ -54,7 +54,7 @@ void action( CallbackMsg cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe( ( Action<CallbackMsg> )action ))
+            using ( mgr.Subscribe<CallbackMsg>( action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -76,7 +76,7 @@ void action( CallbackForTest cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe(JobID.Invalid, ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( JobID.Invalid, action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -98,7 +98,7 @@ void action( CallbackForTest cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe( ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -118,7 +118,7 @@ void action( CallbackForTest cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe(123, ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( 123, action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -140,7 +140,7 @@ void action( CallbackForTest cb )
                 didCall = true;
             }
 
-            using (mgr.Subscribe(123456, ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( 123456, action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -159,7 +159,7 @@ void action( CallbackForTest cb )
                 callCount++;
             }
 
-            using (mgr.Subscribe( ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( action ) )
             {
                 PostAndRunCallback(callback);
             }
@@ -180,7 +180,7 @@ void action( CallbackForTest cb )
                 numCallbacksRun++;
             }
 
-            using (mgr.Subscribe( ( Action<CallbackForTest> )action ))
+            using ( mgr.Subscribe<CallbackForTest>( action ) )
             {
                 for (var i = 0; i < 10; i++)
                 {

diff --git a/SteamKit2/Tests/StreamHelpersFacts.cs b/SteamKit2/Tests/StreamHelpersFacts.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Concurrent;
+using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Threading;
@@ -72,7 +73,7 @@ static IConvertible ReadValue(int threadNumber, Stream s)
                     4 => s.ReadUInt32(),
                     5 => s.ReadInt64(),
                     6 => s.ReadUInt64(),
-                    _ => throw new Exception( "Unreachable" ),
+                    _ => throw new UnreachableException(),
                 };
             }
         }