Replies: 2 comments
-
Hello! My main focus was to follow the XGB SK-API as closely as possible so that XGBLSS can be used as a drop-in replacement for XGB, should users wish to compare familiar XGB models to XGBLSS. My understanding is the XGB SK-API attempts to follow the HistGradientBoostingRegressor as closely as possible. Of course, there are clear gaps in this API w.r.t to prob regression, hence my eagerness for some kind of guidance on an API from the sklearn team. I also wanted to respect the XGBLSS API as much as possible. At the time I wasn't aware of skpro. It seems to me that adopting this well established API makes sense. In the future, I'm sure sklearn and skpro will converge, or at least remain very well aligned. This does me breaking from the XGBLSS API of Additionally, there should be very little overhead if we wish to support both APIs. |
Beta Was this translation helpful? Give feedback.
-
@fkiraly Thanks for suggesting the skpro integration. Integrating the LSS-models into both skpro and sktime would be a fantastic extension! @joshdunnlime Thanks also for PR on the sklearn integration, great effort. I have to admit, though, that I am currently extremely short on time, so that it would take some time for me to review @joshdunnlime's PR first. If that is done, we can start working on the skpro/sktime integration. @joshdunnlime Would you see yourself volunteering for this as well? Would be great! I see that we need to make some adjustments to the current LSS models, especially when it comes to |
Beta Was this translation helpful? Give feedback.
-
It would be great to integrate this package - and adjacent ones like
LightGBMLSS
- withskpro
, which in turn directly integrates withsktime
for time series forecasting.(both of course integate seamlessly with
sklearn
)Issue opened here: sktime/skpro#184
This is very similar to the suggestion of @joshdunnlime for
sklearn
interface,skpro
provides interface specifications and stringent tests (no need to write new ones!) for probabilistic tabular regressors already.What would be needed is, as far as I see it:
predict_proba
interfaceXGBoostLSS
implemented asskpro
tabular distributionsArchitecturally, there are two options:
XGBoostLSS
, and work done inskpro
in interfacingcheck_estimator
fromskpro
(works on distribution objects as well as on estimators), and use that to create fullyskpro
conformant interfaces withinXGBoostLSS
. Then have a light import wrapper inskpro
.skpro
already has an adapter totensorflow
for distributions.Personally, I would think option 1 is preferable at least for the distributions, since the different distribution types are of general use, including for
statmixedML
's other packages, so it would avoid duplication of distribution objects or interfaces.Beta Was this translation helpful? Give feedback.
All reactions