Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(import_transform): skip records with import_transform_skip set #3193

Merged
merged 3 commits into from
Nov 7, 2024
Merged

feat(import_transform): skip records with import_transform_skip set #3193

merged 3 commits into from
Nov 7, 2024

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Nov 7, 2024 •
edited
Loading

Problem:

  • IMPORT_TRANSFORM/IMPORT_TRANSFORM_STRIP need to be able to skip certain records.

Solution:

  • With this PR, if the metadata for a record includes "import_transform_skip" (any value), that record is skipped

@tlimoncelli
Copy link
Contributor Author

@costasd Hi Costas! It looks like NS1 has finally disabled URLFWD: https://github.com/StackExchange/dnscontrol/actions/runs/11731300660/job/32681410264

@tlimoncelli tlimoncelli merged commit df8f8a6 into main Nov 7, 2024
18 checks passed
@tlimoncelli tlimoncelli deleted the tlim_ignoremeta branch November 7, 2024 22:21
@costasd
Copy link
Contributor

costasd commented Nov 11, 2024

@tlimoncelli ah nice, will prepare a PR to remove it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlimoncelli @costasd