Update A_B.ipynb #161
Open
Update A_B.ipynb #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarx
reviewed
Dec 24, 2022
nbs/A_B.ipynb
Outdated
| @@ -270,6 +261,7 @@ | |||
| "# not a fan of this name. maybe call this section \"experiments\"?\n", | |||
| "differentiators:\n", | |||
| " test_case_A:\n", | |||
| " host: grpc-staging.stability.ai:443\n", | |||
There was a problem hiding this comment.
pretty sure we don't want this endpoint to be the notebook default, since this notebook will be public and I'm pretty sure this endpoint isn't supposed to be. for cases where we want to test against this endpoint, we can distribute an appropriate config file that has it as a test case like this
There was a problem hiding this comment.
Oh I see. Very thoughtful. Thanks!
dmarx
suggested changes
Dec 24, 2022
No staging - external use
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow both staging ad production on different test cases. Unitize'grpc_host‘ and ’host‘