-
Notifications
You must be signed in to change notification settings - Fork 12
/
log.txt
59 lines (43 loc) · 1.7 KB
/
log.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
Stef 24/05
==============================================================
Chapter Case study one
- needs reading
- can you check the vocabulary (subpresenter)
- we should decide for the instance variable names pointing to subpresenters.-
And potentially revisit the code
- needs transmission explanation,
- Style (I have the impression that I understand)
- GTK
- conclusion(I will write it)
For now I will not touch it except the conclusion and focus on looking at what we have.
About instance variable names
testSelectingOneFilmDisplaysIt
| list |
list := ImdbFilmListPresenter new.
list openWithSpec.
self assert: list detail nameText text isEmpty.
list filmList clickAtIndex: 1.
self deny: list detail nameText text isEmpty.
To me presenter instance variable should be named ending with presenter (because they are subpresenters)
this way we can have shortcut to access the data inside.
testSelectingOneFilmDisplaysIt
| list |
list := ImdbFilmListPresenter new.
list openWithSpec.
self assert: list detailPresenter namePresenter text isEmpty.
listPresenter filmListPresenter clickAtIndex: 1.
self deny: list detailPresenter namePresenter isEmpty.
This shows that in fact we should write
testSelectingOneFilmDisplaysIt
| list |
list := ImdbFilmListPresenter new.
list openWithSpec.
detail := list detailPresenter.
self assert: detail namePresenter text isEmpty.
list filmListPresenter clickAtIndex: 1.
self deny: detail namePresenter isEmpty.
This way there is no confusion we know about what we are talking.
Once we agree I will rewrite all the chapter.
Because this is important that the book shows good practices.
S.
============================================================