Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price pinning API tweaks #676

Open
ChrisSchinnerl opened this issue Aug 7, 2024 · 0 comments
Open

Price pinning API tweaks #676

ChrisSchinnerl opened this issue Aug 7, 2024 · 0 comments
Assignees

Comments

@ChrisSchinnerl
Copy link
Member

Key name consistency: I’ll consider the autopilots key inconsistency. I guess it could indeed be autopilotPins but it’s a map of autopilot id -> pins. The MaxRPCPrice is an oversight, I’ll change that.
Will fix the misspelling
Qa: Yeah there’s no conversion happening so the units carry over
Qb: I don’t mind adding a default forex API, definitely if it helps with UX. I’ll add that!

@alexfreska alexfreska added this to Sia Jul 31, 2024
@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants