[Bug]: shopify theme share uploads files ignored in .shopifyignore

[hsdonkin]

Please confirm that you have:

• Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
• Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

When uploading a theme via shopify theme share, files included in the .shopifyignore should not be uploaded

package.json
package-lock.json
node_modules
node_modules/

Actual behavior

Ignored files are uploaded, and upload hangs due to number of files in node_modules 😅

Reproduction steps

1. Install any npm packages, i.e. npm init && npm i preact
2. Add package.json and package-lock.json and node_modules to .shopifyignore
3. shopify theme share

Operating System

OSX 11.5.1

Shopify CLI version (check your project's package.json if you're not sure)

3.4.2

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

[github-actions]

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

[beelarr]

I am running into a related issue where using theme share in CI throws this error. package.json: package.json is not a theme file. Our .shopifyignore contains the package.json so it seems like theme share is ignoring the .shopifyignore

@shopify/cli/3.44.1 darwin-arm64 node-v19.8.1

[github-actions]

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

[stevehimmself]

I am experiencing the same issue with Shopify.

[johnphillipsdev]

Running into the same issue, moving the theme files into its own directory is helpless too as Shopify can't find them via subdirectories on the store connection.

[karreiro]

Thank you for reporting this issue, @hsdonkin. It's being solved by #4578.