From e598e6ab9b0809ee53cdf1e0ae624a3683257469 Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Wed, 16 Oct 2024 10:40:58 +0200 Subject: [PATCH 1/3] Delete reviewers-reminder.yml --- .github/workflows/reviewers-reminder.yml | 27 ------------------------ 1 file changed, 27 deletions(-) delete mode 100644 .github/workflows/reviewers-reminder.yml diff --git a/.github/workflows/reviewers-reminder.yml b/.github/workflows/reviewers-reminder.yml deleted file mode 100644 index 09eabe118b..0000000000 --- a/.github/workflows/reviewers-reminder.yml +++ /dev/null @@ -1,27 +0,0 @@ -name: Reviewers reminder - -on: - pull_request: - types: - - opened - -jobs: - remind: - name: "[PR] Remind reviewers" - runs-on: ubuntu-latest - if: github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.user.login != 'dependabot[bot]' - steps: - - name: comment PR - uses: unsplash/comment-on-pr@ffe8f97ccc63ce12c3c23c6885b169db67958d3b # pin@v1.3.0 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - msg: | - Thanks for your contribution! - - Depending on what you are working on, you may want to request a review from a Shopify team: - - Themes: @shopify/advanced-edits - - UI extensions: @shopify/ui-extensions-cli - - Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship - - Hydrogen: @shopify/hydrogen - - Other: @shopify/app-inner-loop From 6184b0efa9ab3dbeafdc471055c424f770ba7f4b Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Wed, 16 Oct 2024 10:41:22 +0200 Subject: [PATCH 2/3] Update codeowners to better handle changesets --- .github/CODEOWNERS | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 077d15f39f..417a0bd157 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,5 +1,7 @@ # By default, review should come from the app-inner-loop team * @shopify/app-inner-loop -# Theme team, or CLI owners can review theme changes -packages/theme/* @shopify/advanced-edits @shopify/app-inner-loop +# Theme team can review theme changes +packages/theme/* @shopify/advanced-edits + +.changeset/* @shopify/advanced-edits @shopify/app-inner-loop From 130097d4ebaeb817c311af0709dd51d46387fe5e Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Wed, 16 Oct 2024 11:03:56 +0200 Subject: [PATCH 3/3] Add back app-inner-loop as reviewer for theme code --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 417a0bd157..af73d428a8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,7 @@ # By default, review should come from the app-inner-loop team * @shopify/app-inner-loop -# Theme team can review theme changes -packages/theme/* @shopify/advanced-edits +# Theme team or CLI owners can review theme changes +packages/theme/* @shopify/advanced-edits @shopify/app-inner-loop .changeset/* @shopify/advanced-edits @shopify/app-inner-loop