Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @headlessui/react to latest #1851

Open
Sendouc opened this issue Aug 25, 2024 · 1 comment
Open

Upgrade @headlessui/react to latest #1851

Sendouc opened this issue Aug 25, 2024 · 1 comment
Labels
help wanted Anyone is free to pick up this issue

Comments

@Sendouc
Copy link
Owner

Sendouc commented Aug 25, 2024

Some API changes.

Should do manual validation on the UI elements that it still works the same after upgrade (as well as fixing the type errors etc.)
@Sendouc Sendouc added the help wanted Anyone is free to pick up this issue label Aug 25, 2024
ElementUser added a commit to ElementUser/sendou.ink that referenced this issue Aug 25, 2024
@ElementUser
Upgraded @headlessui/react to latest version (2.1.3)
8a3b5b8 
- Refactored many Component.Subcomponent (which are marked as deprecated by VSCode) to the separate/more direct imports (e.g. "Combobox.Input -> ComboboxInput)
- Issue Link: Sendouc#1851
This was referenced Aug 25, 2024
Closed
Closed
@ElementUser
Copy link
Contributor

ElementUser commented Sep 1, 2024 •
edited
Loading

Left a comment in my MR, but copy-pasting it here just in case (with regards to the "left-shifting" issue):

So I took a look at the @headlessui/react Repo and it is a confirmed issue with the version of the library itself. Someone else reported a bug that is very similar to this (very likely the same issue): tailwindlabs/headlessui#3396

So it's best to not proceed with the upgrade until they fix it in a later version. However, we can keep an eye on this linked Github issue at least =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Anyone is free to pick up this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElementUser @Sendouc