Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing features #29

Open
Jupi007 opened this issue Aug 18, 2023 · 3 comments
Open

Missing features #29

Jupi007 opened this issue Aug 18, 2023 · 3 comments

Comments

@Jupi007
Copy link
Contributor

Jupi007 commented Aug 18, 2023

Hi @SergeShkurko,
I noticed that you have done a big update of this package, and it looks like there are a lot less problems than with fantasticon.
I really wanted to use it to build the yaru_icons package, but it's missing a lot of features compared to the previous version.
So I've patched it in my fork to add them:

  • Naming strategy (snake/camel) ;
  • consider folder name ;
  • allow hyphens in filenames ;
  • all icons map ;
  • symlink support.

I'd like to know if you'd be open to some PRs to add these features?

@SergeShkurko
Copy link
Member

Yes

@Jupi007
Copy link
Contributor Author

Jupi007 commented Oct 1, 2023

Awaiting for my first PR merge, I implemented all the missing features in my fork: https://github.com/Jupi007/icon_font_generator/tree/dev

@ghost
Copy link

ghost commented Oct 1, 2023

PR opened #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants