Updates to ARCore 1.46.0 and filament 1.56.0 and kotlin 2 and API 35 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Crash in SceneView when calling pickNode() which can throw an exception but isn’t caught when destroying the view - Crash in ArSceneView when view is destroying that could be attempting to double destroy
|
I see I also included another commit we have been using in our local build of the libraries to handle some crashes we would see in production via our Crashlytics logs. Those changes addressed our issues so it might be useful in general but feel free to push back there. Thanks again for an awesome library as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While inspecting an app I work on, I noticed that some of our packaged native shared libraries were not aligned to support 16KB page sizes which are now a possibility with Android 15.
Specifically the filament and gltfio libraries:
To fix this, we would need to update to a newer version of Filament and a newer version of AGP so that when the project was rebuilt, the libraries would be properly aligned.
While making those changes, I went ahead and updated other dependencies listed below:
Compile/Target SDK 34 -> 35
Kotlin 1.9.24 -> 2.0.21
Gradle 8.7 -> 8.9
AGP 8.4.1 -> 8.7.2
Compose Plugin 2.0.21
ARCore 1.43.0 -> 1.46.0
Filament 1.52.0 -> 1.56.0
Since this involved a material version change, I went ahead and updated the materials that are included in the AAR libraries (but I may not have updated all the materials referenced in various sample projects).
Regenerated various materials:
and
and regenerated environments:
I used examples of the
matcandcmgencommands referenced in this repo to generate the commands I listed above.Anyways, this may be an incomplete PR if I missed some materials but I wanted to provide it in case it was useful for ongoing migration efforts.