Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donwload policy on_demand supported for file type repository #16960

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Donwload policy on_demand supported for file type repository #16960

merged 1 commit into from
Nov 27, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Nov 20, 2024 •
edited
Loading

see Katello/katello#11184

Problem Statement

see title

Solution

adapt tests

Related Issues

relevant tests
tests/foreman/cli/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

tests/foreman/api/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

@dosas dosas added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 20, 2024
@dosas dosas requested a review from a team as a code owner November 20, 2024 08:57
@Satellite-QE
Copy link
Collaborator

Can one of the admins verify this patch?

vsedmik
vsedmik requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dosas. Could you please rebase/resolve conflict since #16961 got merged?
Please update the docstrings too. Thank you!

@dosas dosas force-pushed the download-policy-on-demand-file-type branch from 7ff0318 to 1101502 Compare November 26, 2024 13:22
@dosas dosas requested a review from vsedmik November 26, 2024 13:22
@dosas dosas force-pushed the download-policy-on-demand-file-type branch from 1101502 to 37d89f2 Compare November 26, 2024 13:24
@dosas
Copy link
Collaborator Author

dosas commented Nov 26, 2024

Hello @dosas. Could you please rebase/resolve conflict since #16961 got merged? Please update the docstrings too. Thank you!

@vsedmik done

vsedmik
vsedmik approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosas
Copy link
Collaborator Author

dosas commented Nov 27, 2024

@vsedmik How many reviews do we need? Is one enough?

@damoore044
Copy link
Contributor 

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy tests/foreman/cli/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

@damoore044
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9472
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy --external-logging
Test Result: ================== 3 passed, 32 warnings in 513.83s (0:08:33) ==================

damoore044
damoore044 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PRT pass, thank you

@damoore044 damoore044 added the Stream Introduced in or relating directly to Satellite Stream/Master label Nov 27, 2024
@damoore044 damoore044 merged commit 61a498c into SatelliteQE:master Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@dosas dosas

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dosas @Satellite-QE @damoore044 @vsedmik