Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an UI test case for capsule content counts granularity #16820

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add an UI test case for capsule content counts granularity #16820

merged 1 commit into from
Nov 29, 2024
+135 −0

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 30, 2024 •
edited
Loading

Problem Statement

In 6.17 capsule content counts will be updated separately for each CV when it is synced to the capsule and we should have a test case to cover that.

There is currently a bug discovered by this test case, so the PRT is expected to fail on 2 assertions until the issue is resolved:
https://issues.redhat.com/browse/SAT-29679

Solution

This PR just adds UI coverage, more functional testing is added in CLI counterpart.

PRT test Cases example

Requires
Katello/katello#11176 (merged, in snap)
Katello/katello#11187 (merged, in snap)
Katello/katello#11235
SatelliteQE/airgun#1605

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k granular
airgun: 1605
Katello:
  katello: 11235

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 30, 2024
@vsedmik vsedmik self-assigned this Oct 30, 2024
@vsedmik vsedmik mentioned this pull request Oct 30, 2024
Merged
@vsedmik vsedmik marked this pull request as ready for review November 25, 2024 17:52
@vsedmik vsedmik requested a review from a team as a code owner November 25, 2024 17:52
@LadislavVasina1
Copy link
Contributor 

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k 'test_positive_content_counts_granular_update'
airgun: 1605

@LadislavVasina1 LadislavVasina1 added the UI Issues and PRs involving the UI label Nov 25, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 25, 2024 

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k granular
airgun: 1605
Katello:
    katello: 11235

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9460
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_capsulecontent.py -k granular --external-logging
Test Result : ========== 1 passed, 2 deselected, 18 warnings in 2077.55s (0:34:37) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 25, 2024
@vsedmik vsedmik mentioned this pull request Nov 26, 2024
Merged
pondrejk
pondrejk approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, minor question

tests/foreman/ui/test_capsulecontent.py
details['content'][lce.name][cv.name]['expanded_repo_details'][1] == empty_counts
for lce in [lce1, lce2]
for cv in cvs
), 'Expected "N/A" for content counts displayed'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not displayed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant something like Expected "N/A" being displayed for the content counts.
image

LadislavVasina1
LadislavVasina1 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pondrejk pondrejk merged commit 12f1ebd into SatelliteQE:master Nov 29, 2024
12 checks passed
@vsedmik vsedmik deleted the ui-ccc-granularity branch November 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @LadislavVasina1 @Satellite-QE @pondrejk