Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom books #54

Open
wisarmy opened this issue Nov 24, 2023 · 4 comments
Open

Add support for custom books #54

wisarmy opened this issue Nov 24, 2023 · 4 comments

Comments

@wisarmy
Copy link

wisarmy commented Nov 24, 2023

Specify a book file (such as TXT) , by paragraph typing test

@wisarmy
Copy link
Author

wisarmy commented Nov 24, 2023

I want to add this feature, can you give me a code design idea?

@benliepert
Copy link
Contributor

I would look at how word lists are used currently. Conceptually, a custom book is sort of like a word list with randomization in terms of which group of words you're typing (a random starting point in the book) as opposed to randomly picking words to form the group. But the test shouldn't care where it got its words from, so maybe design an interface to wrap book + wordlist functionality

@wisarmy
Copy link
Author

wisarmy commented Nov 29, 2023

main...wisarmy:toipe:feature-book
The issue purpose is to test meaningful sentences in books, not random words.
I submitted an immature implementation, still missing the status of the position in the book

@benliepert
Copy link
Contributor

Nice! looks good. I have a couple suggestions when you create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants