Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Demos Button-group: Add more designs for better understanding of the combinations #2373

Open
turolopezsanabria opened this issue Oct 4, 2022 · 5 comments

Comments

@turolopezsanabria
Copy link
Contributor

turolopezsanabria commented Oct 4, 2022

Acceptance Criteria

The demo should show more combinations of buttons. At this moment it looks like the only valid appearance is with Primary Buttons, when in fact other Colours are also valid.

Definition of done (DOD)

Add a new section colours between size and mode. See the screenshot attached.
Use accent and neutral as examples.

https://sui-components.vercel.app/workbench/molecule/buttonGroup/demo

221004 - Colours

@Malay-dev
Copy link

Can you provide some additional info, like where do you want to add this demo section?

@turolopezsanabria
Copy link
Contributor Author

Sure thing!
it should be between size and mode.

https://sui-components.vercel.app/workbench/molecule/buttonGroup/demo

@Malay-dev
Copy link

Hey, Can you please guide me on how to simulate and test my code on localhost? @turolopezsanabria

@andresin87
Copy link
Member

andresin87 commented Oct 7, 2022

npm run respawn

and then
npm run dev molecule/buttonGroup

@Malay-dev
Copy link

image
On npm run dev molecule/buttonGroup - it is giving the above-mentioned error, How should I resolve this? @andresin87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants