Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typos -> LSM6DSO #146

Open
capiman opened this issue Oct 12, 2021 · 2 comments
Open

More typos -> LSM6DSO #146

capiman opened this issue Oct 12, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@capiman
Copy link

capiman commented Oct 12, 2021

I was initially not aware that each directory is for one sensor.
I thought it is a software variant (or X as place holder for some hardware variants)
and even wanted to question here what is different between each directory, e.g.
like LSM6DSO, LSM6DSOX, LSM6DSO32, LSM6DSO32X.

Question beside: Are they in some kind (backward) compatible?
So e.g. code for LSM6DSO can run on all other mentioned device (when not using the additional features)?

But back to LSM6DSO source code:

Minor:
https://github.com/STMicroelectronics/STMems_Standard_C_drivers/blob/master/lsm6dso_STdC/examples/lsm6dso_self_test.c#L307

LIS2DH12_GY_ST_NEGATIVE
->
LSM6DSO_GY_ST_NEGATIVE

https://github.com/STMicroelectronics/STMems_Standard_C_drivers/blob/master/lsm6dso_STdC/examples/lsm6dso_self_test.c#L348

lsm6dso_xl_data_rate_set(&dev_ctx, LSM6DSO_GY_ODR_OFF);
->
lsm6dso_gy_data_rate_set(&dev_ctx, LSM6DSO_GY_ODR_OFF);

(same as #142 )

I am at the moment using only self test code, so not checked the other example files.

@capiman capiman added the bug Something isn't working label Oct 12, 2021
@capiman
Copy link
Author

capiman commented Oct 13, 2021

Searching over complete repo gives following result:

$ grep -r xl_data_rate_set * | grep -e "GY"
lsm6ds3tr-c_STdC/examples/lsm6ds3tr_c_self_test.c: lsm6ds3tr_c_xl_data_rate_set(&dev_ctx, LSM6DS3TR_C_GY_ODR_OFF);
lsm6dso_STdC/examples/lsm6dso_self_test.c: lsm6dso_xl_data_rate_set(&dev_ctx, LSM6DSO_GY_ODR_OFF);
lsm6dsrx_STdC/examples/lsm6dsrx_self_test.c: lsm6dsrx_xl_data_rate_set(&dev_ctx, LSM6DSRX_GY_ODR_OFF);
$

lsm6dsrx_STdC/examples/lsm6dsrx_self_test.c: //lsm6dsrx_xl_self_test_set(&dev_ctx, LIS2DH12_XL_ST_NEGATIVE);

@avisconti
Copy link
Contributor

I was initially not aware that each directory is for one sensor. I thought it is a software variant (or X as place holder for some hardware variants) and even wanted to question here what is different between each directory, e.g. like LSM6DSO, LSM6DSOX, LSM6DSO32, LSM6DSO32X.

Question beside: Are they in some kind (backward) compatible? So e.g. code for LSM6DSO can run on all other mentioned device (when not using the additional features)?

They are somehow backward compatible, yes.

But back to LSM6DSO source code:

Minor: https://github.com/STMicroelectronics/STMems_Standard_C_drivers/blob/master/lsm6dso_STdC/examples/lsm6dso_self_test.c#L307

LIS2DH12_GY_ST_NEGATIVE -> LSM6DSO_GY_ST_NEGATIVE

https://github.com/STMicroelectronics/STMems_Standard_C_drivers/blob/master/lsm6dso_STdC/examples/lsm6dso_self_test.c#L348

lsm6dso_xl_data_rate_set(&dev_ctx, LSM6DSO_GY_ODR_OFF); -> lsm6dso_gy_data_rate_set(&dev_ctx, LSM6DSO_GY_ODR_OFF);

(same as #142 )

I am at the moment using only self test code, so not checked the other example files.

OK, thanks!
Maybe you can try to provide again a PR, like you already did. Just mention the number of this bug with '#'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants