Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on IDs #155

Open
2 of 6 tasks
abojchevski opened this issue Dec 2, 2015 · 0 comments
Open
2 of 6 tasks

Remove dependencies on IDs #155

abojchevski opened this issue Dec 2, 2015 · 0 comments
Assignees
Milestone

Comments

@abojchevski
Copy link
Collaborator

abojchevski commented Dec 2, 2015

Some classes in nalaf depend on directly, instead of as a parameter.

PRO_CLASS_ID = 'e_1'
MUT_CLASS_ID = 'e_2'
ORG_CLASS_ID = 'e_3'
PRO_REL_MUT_CLASS_ID = 'r_4' # e_1/e_2
PRO_REL_ORG_CLASS_ID = 'r_5' # e_1/e_3

  • nala depends on nala constants (not nalaf's)
  • relna depends on relna constants (not nalaf's)
  • Remove those dependencies from nalaf completely (that means no default param values either)
  • Remove the constants
  • Change it in nala such that you provide now as param the IDs that once were assumed as default
  • Change in relna
@abojchevski abojchevski added this to the 2-ThisWeek milestone Dec 2, 2015
@juanmirocks juanmirocks self-assigned this Feb 4, 2016
@juanmirocks juanmirocks modified the milestones: 3-Next, 2-ThisWeek Feb 4, 2016
@juanmirocks juanmirocks modified the milestones: 2-ThisWeek, 3-Next Jun 23, 2016
juanmirocks added a commit to Rostlab/nala that referenced this issue Jun 24, 2016
juanmirocks added a commit to Rostlab/relna that referenced this issue Jun 24, 2016
@juanmirocks juanmirocks modified the milestones: 4-Upcoming, 3-Next Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants