Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for new emojis in v5 (closes #1020) #1431

Closed
wants to merge 2 commits into from

Conversation

Vansh5632
Copy link

Summary

This PR addresses issue #1020 by adding support for new emojis in Rocket.Chat v5, particularly handling ZWJ (Zero Width Joiner) emoji sequences in the MessageEmoji and MessageEmojiBase components.

Changes

  • Updated MessageEmojiBase to detect and render ZWJ sequences.
  • Modified the MessageEmoji component to ensure proper handling of new emojis in v5.

Testing

  • Tested various ZWJ emoji sequences to confirm they render correctly in Rocket.Chat v5.
  • Passed all existing tests and added new tests for ZWJ sequences.

Related Issue

Closes #1020

Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: a776b08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vansh5632 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vansh5632 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Vansh5632
Copy link
Author

i have signed the CLA but it is showing only CLA not signed please look upon it

@Vansh5632 Vansh5632 closed this Aug 27, 2024
@Vansh5632 Vansh5632 deleted the fix-emoji-1020 branch August 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New emojis not supported in v5
2 participants