Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure hovered option gets un-hovered properly #1412

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

devanshkansagra
Copy link

@devanshkansagra devanshkansagra commented Jul 22, 2024

Proposed changes (including videos or screenshots)

This was a basic one line fix, in the MenuOption.tsx. I had removed 'rcx-option--focus', from the line focus && 'rcx-option--focus', in the className array, due to that and condition the class was not getting removed even if the item is unhovered.

Screencast.from.2024-07-22.20-28-12.webm

Issue:

Fixes: #1361

Further comments

Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: 8d2029b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devanshkansagra
Copy link
Author

Hey maintainer, Can you please review this pull request?

@devanshkansagra devanshkansagra changed the title Fix: ensure hovered option gets un-hovered properly fix: ensure hovered option gets un-hovered properly Sep 14, 2024
@devanshkansagra
Copy link
Author

Hey @umangutkarsh can you please review this pull request? So that if there are any changes to be made I can follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu: Hovered option doesn't get un-hovered
2 participants