Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TelephonicInput: requires validation for number , '+' and braces only #1332

Open
SySagar opened this issue Mar 22, 2024 · 6 comments · May be fixed by #1469
Open

TelephonicInput: requires validation for number , '+' and braces only #1332

SySagar opened this issue Mar 22, 2024 · 6 comments · May be fixed by #1469

Comments

@SySagar
Copy link

SySagar commented Mar 22, 2024

Description
Currently the telephonic input accepts anything i.e. strings, numbers, symbols like %,&,) etc. It should be made to accept only numbers with few paramters like + and ()

Steps to reproduce

  1. Go to fuselage components

  2. Type anything inside the text field

  3. It should show it as invalid rather it doesn't shows anything

Insert an image/gif
Capture

@preeesha
Copy link

preeesha commented Apr 6, 2024

Thanks for reporting the issue @SySagar.

I am working on this.

@SySagar SySagar changed the title TelephonicInput: requires regex for number , '+' and braces only TelephonicInput: requires validation for number , '+' and braces only Apr 16, 2024
@SySagar
Copy link
Author

SySagar commented Apr 16, 2024

@dougfabris Should I start working on this?

@preeesha
Copy link

Hey @SySagar, I am working on this and will create a PR soon.

@SySagar
Copy link
Author

SySagar commented Apr 16, 2024

sure. No problem

@devanshkansagra
Copy link

devanshkansagra commented Oct 22, 2024

I have raised the pull request as this was idle for long time. @SySagar could you please review this pull request so that if there are any changes to be made I will be there to follow up

@utkars3
Copy link

utkars3 commented Nov 1, 2024

@SySagar is the issue still open.I want to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants