Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding function to get group and channel members #73

Open
srrathi opened this issue Nov 26, 2022 · 1 comment
Open

Adding function to get group and channel members #73

srrathi opened this issue Nov 26, 2022 · 1 comment

Comments

@srrathi
Copy link
Contributor

srrathi commented Nov 26, 2022

Problem
Function to get group members already exist in https://github.com/RocketChat/Rocket.Chat.Go.SDK/blob/master/rest/group.go#L45 but the problem with this is it's only for fetching group members. We cannot get channel members through as it have different rest endpoint.

Solution
I'm thinking of to make this function a more generalised function to fetch both group and channel members and we can differentiate between them through type of the room and according to the type it will fetch members from the respected endpoint and just return the members.

Discuss
@geekgonecrazy Should I make it a common function as I said to get both group and channel members or made separate functions for both group and channel in their respective file and call them individually while using according to the type of room ?

@geekgonecrazy
Copy link
Collaborator

I think current design separates between the two, I think the api endpoints is separate as well. Might should follow so those looking at docs for api methods can translate easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants