-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Gitlab Component Kit #98
Open
samad-yar-khan
wants to merge
11
commits into
RocketChat:main
Choose a base branch
from
samad-yar-khan:gitlabComponentKit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[NEW] Gitlab Component Kit #98
samad-yar-khan
wants to merge
11
commits into
RocketChat:main
from
samad-yar-khan:gitlabComponentKit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
force-pushed
the
gitlabComponentKit
branch
from
March 27, 2022 11:17
7266218
to
acf335c
Compare
samad-yar-khan
changed the title
[WIP] [NEW] Gitlab Component Kit
[NEW] Gitlab Component Kit
Mar 27, 2022
This pull request introduces 1 alert when merging acf335c into 0930180 - view on LGTM.com new alerts:
|
@Sing-Li I have added all the necessary to the |
samad-yar-khan
force-pushed
the
gitlabComponentKit
branch
from
April 3, 2022 11:04
934165d
to
03e351d
Compare
This pull request introduces 1 alert when merging 03e351d into 6541e17 - view on LGTM.com new alerts:
|
samad-yar-khan
force-pushed
the
gitlabComponentKit
branch
from
April 11, 2022 17:55
2c24062
to
11e9d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Mentioned in the issue #72
Proposed changes (including videos or screenshots)
New Reusable Gitlab Components Kit
Data fetching method in cms (can be re-used when switching from strapi) to provide a better experience for community builders. All data fetching for the gitalb kit for a repository will be done by a a single
gitlabKit()
function.Introduce Single
<Gitlab ... >
tag which can be used to fetch different components of the kit depending on props/parameters.<Gitlab type={'members'} gitlabData={props.gitlabData} />
Introduce single
gitlabKitData(project_id ,[..needs])
function which can fetch relevant data based on the components we wish to use on a particular page.New Gitlab Merge Request Component
2022-03-27.16-56-32.mp4
/gitlab
2022-03-27.14-51-24.mp4