-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[On Hold - Dec 22] Pre commit hooks #51
base: main
Are you sure you want to change the base?
Conversation
sidmohanty11
commented
Jan 25, 2022
- added necessary pre-commit hooks mentioned in the issue #49 under ./githooks
- added a .pre-commit-config.yaml file where we can modify any configuration of the hooks
- added a make script that shall be run to enable these hooks to run, ref: https://www.viget.com/articles/two-ways-to-share-git-hooks-with-your-team/
Why not use husky? Our main repo already uses it. https://github.com/RocketChat/Rocket.Chat/blob/develop/.husky/pre-push |
@debdutdeb we could totally do that, I've added this according to the issue description but let me know if we want to use husky instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contrib.
Pre commit hooks are #1 deterrent to new contributors and bain of bad dev experience (turning many away from our main repo).
At this early stage of our project, we need to keep the onramp simple to attract more contributors and users.
We don't need it yet. Let's revisit this in June.
Please focus your energy on the huge list of project contents TODOs instead of adding project infra elements. |
Sure! |