Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On Hold - Dec 22] Pre commit hooks #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sidmohanty11
Copy link
Contributor

make enable-git-hooks

@debdutdeb
Copy link
Member

debdutdeb commented Jan 25, 2022

Why not use husky? Our main repo already uses it.

https://github.com/RocketChat/Rocket.Chat/blob/develop/.husky/pre-push

@sidmohanty11
Copy link
Contributor Author

@debdutdeb we could totally do that, I've added this according to the issue description but let me know if we want to use husky instead

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib.

Pre commit hooks are #1 deterrent to new contributors and bain of bad dev experience (turning many away from our main repo).

At this early stage of our project, we need to keep the onramp simple to attract more contributors and users.

We don't need it yet. Let's revisit this in June.

@Sing-Li
Copy link
Member

Sing-Li commented Jan 25, 2022

Please focus your energy on the huge list of project contents TODOs instead of adding project infra elements.

@Sing-Li Sing-Li changed the title [NEW] Pre commit hooks [On Hold - June 22] Pre commit hooks Jan 25, 2022
@sidmohanty11
Copy link
Contributor Author

Sure!

@Sing-Li Sing-Li changed the title [On Hold - June 22] Pre commit hooks [On Hold - Dec 22] Pre commit hooks May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants