Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #73: Markdown render while listing all issues of repository #82

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

kanishbodhwani
Copy link
Contributor

Issue(s) #73

Proposed changes (including videos or screenshots)

  • Markdown is fixed with all possible issues that can occur due to URL. Eg - Removed Square brackets , backticks and quotes.

ss

Further comments

  • Removing all the occurrences of NOT-VALID URL characters.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

@kanishbodhwani
Copy link
Contributor Author

@samad-yar-khan Please review this

@kanishbodhwani
Copy link
Contributor Author

@Nabhag8848 Any suggestions ?

@Nabhag8848
Copy link
Contributor

Hey @kanishbodhwani Nice! but i think you mistakenly worked on main branch. Make sure you create new branch and work on that and open PR with branch you created.

@samad-yar-khan
Copy link
Collaborator

@kanishbodhwani , have we considered all cases for this ?

@kanishbodhwani
Copy link
Contributor Author

@samad-yar-khan I'll check and if there is any case left I'll add that too

@samad-yar-khan
Copy link
Collaborator

samad-yar-khan commented Mar 30, 2023

@kanishbodhwani , I think we can maybe handle for cases where the Title has backticks (if they break the app) "FIX Modal" . Sample -> samad-yar-khan/dsa-problemset#42

@kanishbodhwani
Copy link
Contributor Author

@samad-yar-khan I've checked. This code is all we need to remove from a URL

@samad-yar-khan
Copy link
Collaborator

@kanishbodhwani Can this be extended to the method that sends the PR List to the channel ?

@samad-yar-khan samad-yar-khan merged commit 7853438 into RocketChat:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants