Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contribution graph image from /github me command #53

Open
chinma-yyy opened this issue Feb 21, 2023 · 2 comments · May be fixed by #55
Open

Fix contribution graph image from /github me command #53

chinma-yyy opened this issue Feb 21, 2023 · 2 comments · May be fixed by #55
Labels
bug Something isn't working

Comments

@chinma-yyy
Copy link
Contributor

chinma-yyy commented Feb 21, 2023

Description:

When using the /github me command the user is prompted to share the contribution graph image but the contribution graph endpoint does not provide contribution graph image URL and hence the image block is always in loading state.

Steps to reproduce:

  1. Run the app locally
  2. Login through /github login
  3. Type /github me

Expected behavior:

Show user information with contribution graph image and

Actual behavior:

Contribution Graph image URL is not retrieved from the endpoint provided and the image is stuck in loading state

@chinma-yyy chinma-yyy added the bug Something isn't working label Feb 21, 2023
@Nabhag8848
Copy link
Contributor

Nabhag8848 commented Feb 21, 2023

Hey, @chinma-yyy . We are using github-readme-activity-graph project for having the github contribution graph and i have found out that the deployment for the project has been changed to https://github-readme-activity-graph.cyclic.app Thus, it always in loading state. Check here we have old deployment url: https://github.com/RocketChat/Apps.Github22/blob/main/github/helpers/githubActivityGraphURL.ts#L3 thats the thing we will need to change.

  • You can edit this issue for solving the actual issue. Thanks!

@chinma-yyy
Copy link
Contributor Author

Yeah @Nabhag8848 , I noticed the old deployment url but couldnt find the new one. Thank you for the changes, i will update the issue and also solve the issue.

@chinma-yyy chinma-yyy changed the title Remove contribution graph from /github me Fix contribution graph image from /github me command Feb 21, 2023
@chinma-yyy chinma-yyy linked a pull request Feb 21, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants