Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to previous modal when clicked, instead of Close #147

Open
1 task
umangutkarsh opened this issue Apr 21, 2024 · 4 comments
Open
1 task

Go back to previous modal when clicked, instead of Close #147

umangutkarsh opened this issue Apr 21, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@umangutkarsh
Copy link

Why do we need this ?

To make the user experience better.
Currently, when this command -> /github Username/RepositoryName pulls is entered, action buttons along with link to PR are rendered. And in the PR actions modal when the desired buttons are clicked, for example - View File, View Changes, Comments, etc, the desired modal is opened up but then there is no option to go back, instead the user has to close the modal and again re-open it to select other option in the PR actions modal.

As a GitHub App developer

I need to: Implement a feature to go back to previous modal (PR actions modal) instead of closing it.

So That: The user doesn't have to re-open the modal again and again which doesn't provide good user experience.

Acceptance Criteria

  • Integrate Go Back option instead of Close submit button in PR Actions modal.

Screenshots/Record

gh-ux.webm
@umangutkarsh umangutkarsh added the enhancement New feature or request label Apr 21, 2024
@umangutkarsh
Copy link
Author

Hi @samad-yar-khan . What do you think about this? Please let me know. Thanks.

@samad-yar-khan
Copy link
Collaborator

samad-yar-khan commented May 5, 2024

@umangutkarsh makes sense. I believe this was earlier inbuilt in RocketChat and they then removed this stacking. I think stacking its like an application UI would make for a better UX. Would you like to work on this ?

@umangutkarsh
Copy link
Author

Yes sure @samad-yar-khan . Is it okay if I give you updates after I make some progress?

Thanks.

@samad-yar-khan
Copy link
Collaborator

yes, please feel free to join the channel : https://open.rocket.chat/channel/GitHub-App-Community-Developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants