Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Merge/Approve/Comments button ambiguous for multiple PR links #136

Open
samad-yar-khan opened this issue Mar 3, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@samad-yar-khan
Copy link
Collaborator

samad-yar-khan commented Mar 3, 2024

Description:

  • The behaviour of PR helper buttons is ambiguous in case of multiple PRs links

Steps to reproduce:

  1. Open channel
  2. Added multiple PR links

image

Expected behavior:

  • We should show buttons incase of single PR Open PR link in channel or come up with a cleaner way to handle this

Actual behavior:

Rocket.Chat Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:

Rocket.Chat Client Setup Information

  • Desktop App Version:
  • Browser Version:
  • Operating System:
  • Android App Version:
  • IOS Application Version:

Additional context

@samad-yar-khan samad-yar-khan added the bug Something isn't working label Mar 3, 2024
@VipinDevelops
Copy link
Contributor

Hey @samad-yar-khan I would like to work on this issue and solve this issue using the new UI kit or some other better method to handle the multiple buttons bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants