Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal props being shoved in on Store change in Wally version #62

Open
thenerdie opened this issue Feb 13, 2022 · 0 comments
Open

Internal props being shoved in on Store change in Wally version #62

thenerdie opened this issue Feb 13, 2022 · 0 comments

Comments

@thenerdie
Copy link

I was integrating multiplayer in my game and I came across this little bug:

Huh, that's funny. I was using an earlier version of RoactRodux and it was fine before switching to the Wally version...

If I print the props before a mapStateToProps call (line 97), like so, and add a print in my mapStateToProps:

I get this output:

After doing a little digging, it turns out that whenever the store updates, it shoves the Connection's raw props into mapStateToProps, instead of the Connection's innerProps.

If I pass in the innerProps like so:

It works like a charm:

@thenerdie thenerdie changed the title Internal props being shoved in on Store change Internal props being shoved in on Store change in Wally version Feb 13, 2022
@Roblox Roblox deleted a comment from applesm18 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant