Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaywallFooter improvements #1862

Open
jscti opened this issue Oct 1, 2024 · 3 comments
Open

PaywallFooter improvements #1862

jscti opened this issue Oct 1, 2024 · 3 comments

Comments

@jscti
Copy link

jscti commented Oct 1, 2024

Paywall footer is great but comes with 2 limitations preventing it to be used freely in any custom page design :

  • PaywallFooter is "fillMaxSize"-d : it prevents any "modal bottomsheet" behavior where the bottomsheet would only appear at the bottom of the screen with low-height content. At the present, the height is always 100% without any possibility to reduce it (a simple Modifier would be great !)
  • PaywallFooter uses a forced systemBar padding (SystemBarsSpacer in the templates) to ensure navigation don't get in the way : OK but what if I already handled that in my UI/Design ?

TLDR: PaywallFooter is forcing a "fullsize modal spirit" where small adjustement could improve its custom use i any UI/design (modal, bottomSheet, any part of the screen)

Using revenuecat = '8.7.2'

Thanks

@RCGitBot
Copy link
Contributor

RCGitBot commented Oct 1, 2024

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@nyeu
Copy link

nyeu commented Oct 3, 2024

Hi @jscti,
Thank you for your feedback! We're currently in the process of reworking paywalls to make them more flexible and provide additional UI options. The PaywallFooter is likely to undergo significant changes, and we'll be sure to incorporate your feedback into the improvements.

@jscti
Copy link
Author

jscti commented Nov 6, 2024

Other irritating things :

  • on a onPurchaseCompleted (listener) the PaywallFooter is internally auto-dismissed... But what If I don't want that ?
  • the "dismissRequest" (from PaywallOptions.Builder) is used for multiple cases and it's hardly usable because non predictable :
    • called in case of "onPurchaseCompleted" = success scenario
    • but also called for example if paywall init crashes (user sideloaded app outside playstore / no play services etc) = failed scenario
  • onPurchaseError listener is not called when trying to buy an already purchased product (non consummable). In the logs I just see "Ignoring purchase request for already subscribed package" but cannot intercept that to give feedback to the user

So yeah, I hope the next version of PaywallFooter will be more flexible and not linked to "dismissable popup" behaviors.
I want it to be added in any of my pages (in a middle of a standard screen like onboarding).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants