Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta issue when loading save states #992

Open
FalcusDev opened this issue Apr 3, 2023 · 1 comment
Open

Delta issue when loading save states #992

FalcusDev opened this issue Apr 3, 2023 · 1 comment

Comments

@FalcusDev
Copy link

I've noticed this quite a few times whilst developing achievements, however when you load a save state, if the achievement has a delta condition, the delta check will compare the state of the game on the frame the state is loaded against the state of the game prior to loading the save state.
Because of this, it's possible to incorrectly trigger conditions within an achievement due to the different states of the memory before and after loading a save state.

One example would be if you made a save state during a damageless boss fight attempt, healed yourself, then loaded the save state, the achievement would then pause lock because it detects your health decreasing from the state before loading the save state to after.

The only solution I've found for this whilst testing my own achievements is to load a save state twice in a row.

@Jamiras
Copy link
Member

Jamiras commented Apr 3, 2023

Delta information and hit counts should be stored in the save state as well. The caveat is if the achievement definition has changed, the achievement is just reset instead of being loaded from the save state, so both delta and hit count will be 0 for the frame in which it's loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants