Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5 #15

Open
alganet opened this issue Feb 18, 2012 · 9 comments
Open

HTML5 #15

alganet opened this issue Feb 18, 2012 · 9 comments

Comments

@alganet
Copy link
Member

alganet commented Feb 18, 2012

Seems that I broke HTML5 support in one of my commits.
@alganet
Copy link
Member Author

alganet commented Feb 23, 2012

This could be related to the libxml version, since the PHP DOM parser uses this library.

@augustohp
Copy link
Member

Actually, i am quite suspicius of libxml on lots of things ... i will work better on it this weekend =P

@alganet
Copy link
Member Author

alganet commented Feb 23, 2012

We kinda need it. Not a dependency we can rule out =P

@augustohp
Copy link
Member

Sure not, but we can narrow down the problem to version, environment, compilation parameters or whatever is breaking things down.

Not the first time, not the second and it won't be the last time this kinda thing happens ... =P

@alganet
Copy link
Member Author

alganet commented Feb 23, 2012

Agreed!

@nickl-
Copy link
Member

nickl- commented Jun 2, 2012

It is not clear what this issue refers to, maybe close it and start something more descriptive as to not alarm other new users.

This has boon open for 3 months and I don't have a problem using Template with HTML 5.

@nickl-
Copy link
Member

nickl- commented Jun 3, 2012

Let me add to that last statement:

I have the following above the head element

  <!--[if lt IE 7]> <html class="no-js lt-ie9 lt-ie8 lt-ie7" lang="en"> <![endif]-->
  <!--[if IE 7]>    <html class="no-js lt-ie9 lt-ie8" lang="en"> <![endif]-->
  <!--[if IE 8]>    <html class="no-js lt-ie9" lang="en"> <![endif]-->
  <!--[if gt IE 8]><!--> <html class="no-js" lang="en"> <!--<![endif]-->

Which prevents libxml from adding tag.

@alganet
Copy link
Member Author

alganet commented Jun 3, 2012

This was in fact to support ommiting not found tags and supporting the DOCTYPE declararion. Full HTML5 parsing support is hard, maybe only with html5lib. If we could decouple the DOM from Template and add support for html5lib as an alternative parser, users could choose between performance and support.

Not sure if you noticed, but Respect\Template is very early stage. We were surprised by looking you saying that you've been using it. Even we didn't used the component, only created some tests.

We're also very happy with your contributions! Feels like moving forward.

@nickl-
Copy link
Member

nickl- commented Jun 4, 2012

Just the way I like it raw and untamed =)

I stumbled across HtmlElement and fell in love, what a perfect use of overloading I don't see a better example than this. I like the idea of the template and think this can work with very little added effort.

Are you referring to this html5lib but this project has been dragging on forever and the PHP track hasn't had a change in 3 years. I don't feel like struggling with a new broken DOM parser then I'll rather keep the broken one we have.

What exactly could you not detect in HTML5. I somehow think that QueryPath must have these sorted but more on that in a new issue.

@nickl- nickl- mentioned this issue Jun 4, 2012
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@augustohp @alganet @nickl-