Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ro Respect\Doc #22

Open
augustohp opened this issue Mar 26, 2012 · 5 comments
Open

Convert ro Respect\Doc #22

augustohp opened this issue Mar 26, 2012 · 5 comments
Labels

Comments

@augustohp
Copy link
Member

Start using Respect/Doc into project, this implies into:

  • Making many public method protected
  • Creating better unit tests to be used as examples
  • Adding little PHPDoc to some classes and methods
@ghost ghost assigned augustohp Mar 26, 2012
@nickl-
Copy link
Member

nickl- commented Feb 7, 2013

We can make the visibility private if you ask me, does anyone need to decorate a container?
I guess its better to leave the option.

100% code coverage and travis should also be included here.

What is the state of Respect\Doc doesn't it require some special type of tests? (examples if I recall)

@alganet
Copy link
Member

alganet commented Feb 7, 2013

We only need to change visibility of things that aren't meant to be documented. Anything that may be useful as a public attribute (even if there are risks) I believe should be kept public. The risks can be reduced by testing (which improves our docs)! =)

Respect\Doc requires a special test method naming and suggests a test body that can be used as an example, but we only implemented a few of the several patterns for naming we imagined.

@nickl-
Copy link
Member

nickl- commented Feb 8, 2013

I'm on it, also rewriting tests to use a stream wrapper and get 100% coverage completed.

I think the Respect/Doc compatibility should be handled as a separate milestone, driven from that project to render docs for all our projects and not influence the completion of this milestone at all, agreed?

@alganet
Copy link
Member

alganet commented Feb 8, 2013

+1 for separate milestone

@nickl-
Copy link
Member

nickl- commented Feb 8, 2013

Created new milestone and issue at Respect/Doc#18

Issue remains open for 100% coverage.

@alganet alganet removed this from the beta milestone Feb 11, 2015
@augustohp augustohp removed this from the beta milestone Feb 11, 2015
@augustohp augustohp removed their assignment Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants