-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ro Respect\Doc #22
Comments
We can make the visibility private if you ask me, does anyone need to decorate a container? 100% code coverage and travis should also be included here. What is the state of Respect\Doc doesn't it require some special type of tests? (examples if I recall) |
We only need to change visibility of things that aren't meant to be documented. Anything that may be useful as a public attribute (even if there are risks) I believe should be kept public. The risks can be reduced by testing (which improves our docs)! =) Respect\Doc requires a special test method naming and suggests a test body that can be used as an example, but we only implemented a few of the several patterns for naming we imagined. |
I'm on it, also rewriting tests to use a stream wrapper and get 100% coverage completed. I think the Respect/Doc compatibility should be handled as a separate milestone, driven from that project to render docs for all our projects and not influence the completion of this milestone at all, agreed? |
+1 for separate milestone |
Created new milestone and issue at Respect/Doc#18 Issue remains open for 100% coverage. |
Start using Respect/Doc into project, this implies into:
public
methodprotected
The text was updated successfully, but these errors were encountered: