RHCLOUD-30751 Principal Links endpoint fixes #1248
Conversation
|
Can one of the admins verify this patch? |
|
/retest |
rbac/management/principal/view.py
Outdated
| @@ -188,7 +187,7 @@ def get(self, request): | |||
| "first": f"{path}?limit={limit}&offset=0{usernames_filter}", | |||
| "next": f"{path}?limit={limit}&offset={offset + limit}{usernames_filter}", | |||
| "previous": f"{path}?limit={limit}&offset={previous_offset}{usernames_filter}", | |||
| "last": None, | |||
| "last": f"{path}?limit={limit}&offset={int(limit - int(count))}{usernames_filter}", | |||
There was a problem hiding this comment.
if limit < count then offset will be negative
maybe we can reuse the get_paginated_response() from rbac/api/common/pagination.py
There was a problem hiding this comment.
@EvanCasey13 is it possible to leverage get_paginated_response somehow ?
it looks there some cases which needs to covered.
rbac/management/principal/view.py
Outdated
| @@ -183,12 +182,13 @@ def get(self, request): | |||
| count = len(data) | |||
| else: | |||
| count = None | |||
| last_link = int(count) - int(limit) if (int(count) - int(limit)) >= 0 else 0 | |||
There was a problem hiding this comment.
please consider better name for the variable, it should describe the value that is inside
rbac/management/principal/view.py
Outdated
| response_data["meta"] = {"count": count, "limit": limit, "offset": offset} | ||
| response_data["links"] = { | ||
| "first": f"{path}?limit={limit}&offset=0{usernames_filter}", | ||
| "next": f"{path}?limit={limit}&offset={offset + limit}{usernames_filter}", | ||
| "previous": f"{path}?limit={limit}&offset={previous_offset}{usernames_filter}", | ||
| "last": None, | ||
| "last": f"{path}?limit={limit}&offset={last_link}{usernames_filter}", |
There was a problem hiding this comment.
it is needed to fix all links here to work in same way as for other endpoints like GET /groups/ for example GET /principals/ for limit=10 and offset=0 (default values) the previous link should be null
EvanCasey13
changed the title
|
/retest |
Link(s) to Jira
https://issues.redhat.com/browse/RHCLOUD-30751
Description of Intent of Change(s)
Fixed bug where incorrect links were being returned for the principals endpoint
Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist