You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why do you have two examples? The first one seems a bit non-idomatic regarding collecting the prices in a synchronized method, this smells like "shared mutual state"...
What do you think?
Best regards,
Fred
The text was updated successfully, but these errors were encountered:
TexasFred
changed the title
Why do you have two CompletableFuture examples in challenge 1?
Why do you have two CompletableFuture examples for challenge 1?
Feb 13, 2017
Hi there,
I just discovered your repo. You've got interesting stuff there! Congrats!!!
While reading the examples I found two examples for challenge 1 using Java and CompletableFuture
https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/CompletableFutureExample.java
and
https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/GmoCompletableFutureDemo.java
Why do you have two examples? The first one seems a bit non-idomatic regarding collecting the prices in a synchronized method, this smells like "shared mutual state"...
What do you think?
Best regards,
Fred
The text was updated successfully, but these errors were encountered: