Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you have two CompletableFuture examples for challenge 1? #4

Open
TexasFred opened this issue Feb 13, 2017 · 0 comments
Open

Comments

@TexasFred
Copy link

Hi there,

I just discovered your repo. You've got interesting stuff there! Congrats!!!

While reading the examples I found two examples for challenge 1 using Java and CompletableFuture

https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/CompletableFutureExample.java

and

https://github.com/ReactiveMeetupLucerne/AsyncNonBlockingExamplesJVM/blob/master/src/main/java/challenge1/java8/GmoCompletableFutureDemo.java

Why do you have two examples? The first one seems a bit non-idomatic regarding collecting the prices in a synchronized method, this smells like "shared mutual state"...

What do you think?

Best regards,
Fred

@TexasFred TexasFred changed the title Why do you have two CompletableFuture examples in challenge 1? Why do you have two CompletableFuture examples for challenge 1? Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant