Fix: JA+ server modelscale prediction errors

[Razish]

on JA+ servers with modelscale set (e.g. jan on KR server), there are prediction errors when standing on their head

[Razish]

Ping @Blackwolf1337 did you want to look at this before me :)?

[Exmirai]

bboxes are not updated?

[ensiform]

I don't think they are in JA+ either.

[Blackwolf1337]

@Razish I'll take a look at it.

[Blackwolf1337]

Ok, I looked over the code and it seems like there is a prediction... the fault is coming from the Ja+ mod itself, since it's not scaling the Boundary Box as @EpicLoyd asked and said. So it is irrelevant to fix it, since it has to do something Serverside. Since the Size Prediction is built in, it bugs for us because the game thinks, that the model is scaled with the boundary box, which isn't. I think this can be closed @Razish ?

[Razish]

If we are getting prediction errors, the bounding boxes are out of sync with the server.
Either we are updating them with the modelscale and JA+ server is not, or we are not updating them with the modelscale and JA+ is. Right?

[Exmirai]

afaik ja+ not updating it because if resulting bbox ( after scaling ) will be too high or too wide that can block whole map or significant part.

[Blackwolf1337]

@Razish, that's totally right. But your ja++ Plugin already has a prediction for it, when scaling models up and down you're getting the prediction. It's just Ja+.