Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.utilities.encoder.ogg 4.0.0 #27

Merged
merged 3 commits into from
Nov 11, 2024
Merged

com.utilities.encoder.ogg 4.0.0 #27

merged 3 commits into from
Nov 11, 2024

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Nov 11, 2024

  • com.utilities.audio -> 2.0.1
  • refactor StreamSaveToDiskAsync
  • added missing Preserve attributes
  • removed duplicate wav_sample.wav file

copilot summary

This pull request includes several changes to the OggEncoder class in the com.utilities.encoder.ogg package. The changes introduce new methods, update existing methods, and make some structural improvements. Additionally, there are updates to the package version and dependencies.

Enhancements to OggEncoder class:

  • Added [Preserve] attribute to several methods to ensure they are not stripped by the linker. (OggEncoder.cs - [1] [2] [3]
  • Replaced InitOggStream method with WriteOggHeader to improve clarity and functionality. (OggEncoder.cs - [1] [2] [3] [4]
  • Modified StreamSaveToDiskAsync method to use ClipData instead of AudioClip and added exception handling and logging. (OggEncoder.cs - [1] [2] [3] [4] [5]

Package updates:

  • Updated package version to 4.0.0 and changed dependency version for com.utilities.audio to 2.0.1. (package.json - [1] [2]
  • Updated project settings to reflect the new version and active input handler. (ProjectSettings.asset - [1] [2]

Removal of obsolete files:

- com.utilities.audio -> 2.0.0
- refactor StreamSaveToDiskAsync
- added missing Preserve attributes
- removed duplicate wav_sample.wav file
@StephenHodgson StephenHodgson marked this pull request as ready for review November 11, 2024 22:42
@StephenHodgson StephenHodgson merged commit 88f5ff8 into main Nov 11, 2024
11 checks passed
@StephenHodgson StephenHodgson deleted the development branch November 11, 2024 23:03
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
- com.utilities.audio -> 2.0.1
- refactor StreamSaveToDiskAsync
- added missing Preserve attributes
- removed duplicate wav_sample.wav file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant