Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable matmul function #13

Merged
merged 11 commits into from
Mar 12, 2024
Merged

Enable matmul function #13

merged 11 commits into from
Mar 12, 2024

Conversation

pnunna93
Copy link
Collaborator

@pnunna93 pnunna93 commented Mar 12, 2024 •
edited
Loading

This PR enables matmul function on ROCm. It has following fixes:

  • Enables igemmlt in matmul function
  • Fix for output shape in transform function
  • Enables int8 output for igemmlt
  • col format support for extract outliers function
  • row format support for dequant mm kernel

Lzy17
Lzy17 approved these changes Mar 12, 2024
View reviewed changes
Copy link

@Lzy17 Lzy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@pnunna93 pnunna93 merged commit f30dc38 into rocm_enabled Mar 12, 2024
1 check passed
@pnunna93 pnunna93 deleted the enable_matmul branch March 12, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lzy17 Lzy17 Lzy17 approved these changes

@amathews-amd amathews-amd Awaiting requested review from amathews-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnunna93 @Lzy17