Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge leaves split related options in AndroidManifest.xml #114

Closed
HelloKS opened this issue Aug 1, 2024 · 2 comments
Closed

Merge leaves split related options in AndroidManifest.xml #114

HelloKS opened this issue Aug 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@HelloKS
Copy link

HelloKS commented Aug 1, 2024

Describe the bug
After merging X (twitter) 10.52.0, APKEditor leaves "android:requiredSplitTypes" and "android:splitTypes" in AndroidManifest.xml. This resulting non-installable APK.

To Reproduce
Steps to reproduce the behavior:

  1. Using APKEditor v1.3.8 on Windows 11, OpenJDK Termurin-21.0.2
  2. Run java -jar APKEditor-1.3.8.jar m -i com.twitter.android_10.52.0-release.0-310520000_4arch_7dpi_23lang_f0692c4e75b3b936319464d7756ffa31_apkmirror.com.apkm
  3. Run java -jar APKEditor-1.3.8.jar d -t xml -dex -i com.twitter.android_10.52.0-release.0-3 10520000_4arch_7dpi_23lang_f0692c4e75b3b936319464d7756ffa31_apkmirror.com_merged.apk
  4. Open AndroidManifest.xml and observe android:requiredSplitTypes and android:splitTypes are still intact after sanitizing

Used apk bundle file
APKMirror

Additional context
Merging previous version (X 10.51.1) works well and installable

@HelloKS HelloKS changed the title Merge leaves split releated options in AndroidManifest.xml Merge leaves split related options in AndroidManifest.xml Aug 1, 2024
@REAndroid REAndroid added the bug Something isn't working label Aug 1, 2024
@REAndroid
Copy link
Owner

For some reason playstore was using requiredSplitTypes & splitTypes attributes without resource id (handled by #85), using proper resource id is a new change.

Fixed by this commit, build your own or grab from action until next release.

Thank you for reporting

@REAndroid
Copy link
Owner

I assumed this issue is fixed, closing ... reopen it otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@HelloKS @REAndroid and others