Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some rendering mappings #476

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Some rendering mappings #476

merged 3 commits into from
Aug 9, 2023

Conversation

OroArmor
Copy link
Member

@OroArmor OroArmor commented Aug 7, 2023

No description provided.

@OroArmor OroArmor added t: new adds new mappings v: snapshot targets a snapshot version of minecraft reviews needed please review this PR s: small PRs with less than 200 lines labels Aug 7, 2023
EnnuiL
EnnuiL suggested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just a few things:

mappings/net/minecraft/client/render/BuiltChunkStorage.mapping Outdated Show resolved Hide resolved
mappings/com/mojang/blaze3d/texture/TextureUtil.mapping Show resolved Hide resolved
ix0rai
ix0rai approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address ennui's comments and this is great!
also: see #474, you support mipLevel then?

@OroArmor
Copy link
Member Author

OroArmor commented Aug 7, 2023

Yes mipLevel is better

@OroArmor OroArmor added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 9, 2023
@EnnuiL
Copy link
Contributor

EnnuiL commented Aug 9, 2023

Fast-tracking due to new Minecraft snapshot

@EnnuiL EnnuiL merged commit 028b37f into QuiltMC:23w31a Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

@EnnuiL EnnuiL EnnuiL approved these changes

@IotaBread IotaBread IotaBread approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: small PRs with less than 200 lines t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OroArmor @EnnuiL @supersaiyansubtlety @IotaBread @ix0rai